rvesse commented on PR #2501: URL: https://github.com/apache/jena/pull/2501#issuecomment-2144680250
> Also, I understand that this is a large PR. If it would be easier, I can also try to break it into a sequence of smaller PRs, one part at a time; for instance, a first part about reading and writing the literals, a second part that adds the functions (cdt:get, cdt:size, etc), a third one that adds the FOLD aggregate, etc. Let me know if you would prefer such a step-wise process. Breaking into smaller PRs might be useful and likely make it easier to review. However large features can arrive in a single PR (like the recent `jena-ontapi` PR) if that is the most appropriate way to contribute them. It doesn't seem like the individual pieces of functionality necessarily are valuable on their own without the other pieces which would suggest keeping this as a single PR (unless other committers disagree) for the time being. In more practical terms generally we try and keep the commit history relatively succinct given the 20+ year history of the project so squashing the commits down in some form would be useful. Obviously with a contribution of this size squashing to a single commit would be excessive, but the current 180 commits is the opposite extreme. So squashing into some sensible number of commits (and I'll leave that to your judgement) where each commit represents some coherent chunk of development of this feature would be helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For additional commands, e-mail: pr-h...@jena.apache.org
