afs commented on PR #2501: URL: https://github.com/apache/jena/pull/2501#issuecomment-2145099616
While there are a lot of files, it looks to me like the majority are consequences of adding `FOLD` and `UNFOLD` as SPARQL extensions. I've been though the description and the code (to some extent) and I don't a partition into natural commits (as @rvesse says things that operate on their own). So one commit. We can squash as it is merged but then the commit is co-owned. It would be cleaner if the commit has your name on it. I've pulled and built the PR so that looks good. The acceptance gateway includes whether "mvn clean install" completes. That builds Jena - it doen't take too long on a laptop. OR There are also github action in the jena codebase and in the clone you have: https://github.com/hartig/jena/actions/workflows/maven.yml I had to fix one thing the build: jena-arq/src/main/java/org/apache/jena/riot/system/CDTAwareParserProfile.java which does not have the license header. The build runs the "RAT" - Release Audit Tool - catches this in the maven build. "This branch cannot be rebased due to conflicts" - the PR at the moment isn't in line with the jena project main branch. If you pull the Apache main branch into the main of your repo, then do `git rebase main` it will stop for conflicts to be resolved. I tried and the conflicts I looked at were mostly formatting when Jena main had been tidied up a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For additional commands, e-mail: pr-h...@jena.apache.org
