-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Luke Kanies wrote: > > I'm kind of two minds about this. > > On the one hand, I'm having a hard time seeing exactly how it would > work, at least in terms of using email to manage the patch queues. > > On the other hand, David is clearly right that we need more people > looking at the code, and this might be a good way to do it. Further, > the -dev list is largely fallow, and this could go a long way toward > getting more conversation going on the list, and the conversation > might even -- crazy crazy! -- be about code. > > I think we might as well try it. Even if it's not used to actually > approve patches, it would hopefully be a useful way to get more people > looking at the code and commenting on it. >
I like the idea personally - mostly because I want to feel somewhat confident that patches - some of which I don't understand as well as I could or pertain to type/providers that I don't use - are at least partially reviewed. I find having the patch in your face in your email seems to make people look more closely. Obviously there are some issues here with work flow that I am going to try to work through shortly and document. One issue is of course that Trac relies on local repositories and my primary is currently GitHub. We might need to rethink that. Cheers James - -- James Turnbull ([EMAIL PROTECTED]) Author of: * Pulling Strings with Puppet (http://www.amazon.com/gp/product/1590599780/) * Pro Nagios 2.0 (http://www.amazon.com/gp/product/1590596099/) * Hardening Linux (http://www.amazon.com/gp/product/1590594444/) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFINo0P9hTGvAxC30ARAu8wAKCA1zKnoARrEBHq3MMByUAZZc4rdQCgiDlT Sfpo0uRYQUgptfIB8tjoABQ= =vwVl -----END PGP SIGNATURE----- --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
