It then becomes grunt work for reviewers, who also have to carefully balance encouraging new contributors against preventing the code base from getting worse.
I’d rather have a review bot that can detect problems in PRs and comment on them. We can choose to merge anyway and it won’t keep being noisy, but it also saves committers from potentially telling someone their contribution isn’t welcome because of their camelCase. (Maybe Mariatta’s tutorial will build this bot? Maybe I’ll go and learn how to do it myself :) ) (and here ends my contribution on this topic. Pretty sure we're firmly in core-workflow territory now.) Top-posted from my Windows phone From: Ethan Furman Sent: Thursday, February 22, 2018 7:39 To: python-dev@python.org Subject: Re: [Python-Dev] How is the GitHub workflow working for people? On 02/22/2018 02:12 AM, Antoine Pitrou wrote: > Overall it makes contributing more of a PITA than it needs be. Do > automatic style *fixes* if you want, but please don't annoy me with > automatic style checks that ask me to do tedious grunt work on my spare > time. +1 -- ~Ethan~ _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/steve.dower%40python.org
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
