On 14/03/2008, Robert Godfrey <[EMAIL PROTECTED]> wrote: > > > > > > I would like to say that it is all very well having a single time when > > we sit down and code review. That SHOULD NOT meant it is the only > > time. I would like to see us be more proactive in reviewing commits as > > they occur. If various groups wish to sit down and review the code > > independently and report back that is ok by me. But we must remember > > to be inclusive and a single dial in point is not going to cover that. > > If review was occurring continually then there would be no need for > > the weekly call. Something I'm sure we can work towards. > > > > > Agreed... but the problem with diffuse collective repsonsibility like this > (saying everyone *should* be reviewing everything) is that no-one in > particular takes responsibility for it. Until we are better at it I think > we all need to be working together at explicit time.
Totally agree, any steps we can take that will lead to better process is something we should all be behind. I just wanted to highlight the direction we should be aiming to get to. Set review time is way better than 'should' review that never happends. > -- Rob > -- Martin Ritchie
