Robert Godfrey wrote:
I would like to say that it is all very well having a single time when
we sit down and code review. That SHOULD NOT meant it is the only
time. I would like to see us be more proactive in reviewing commits as
they occur. If various groups wish to sit down and review the code
independently and report back that is ok by me. But we must remember
to be inclusive and a single dial in point is not going to cover that.
If review was occurring continually then there would be no need for
the weekly call. Something I'm sure we can work towards.
Agreed... but the problem with diffuse collective repsonsibility like this
(saying everyone *should* be reviewing everything) is that no-one in
particular takes responsibility for it. Until we are better at it I think
we all need to be working together at explicit time.
First off I very much like the proposed process and I'm a big +1 on it,
and I also completely agree that diffuse responsibility is an issue. To
that end we could, in addition to the proposed process, select a lead
for each of the various components of qpid. I'm thinking the
responsibilities of each lead might be to manage JIRAs, and run the code
review for that component.
I think something like this could work well with the proposed process
and provide some non diffuse responsibility without saddling any single
person with e.g. the load of cleaning up all the JIRAs.
--Rafael
