Excellent discovery, awokd and qubes123!
Please try to somehow upstream your solution to Xen.
Idea: find a way to detect a CPU type before executing this
"recheck_cpu_features(0)"
function, and if it is AMD CPU - maybe just skip this check :
> - if ( !recheck_cpu_features(0) )
> +/* if ( cpu_is_not_amd() && !recheck_cpu_features(0) )
> panic("Missing previously available feature(s).");
> -
> +*/
Perhaps this problem affects all the AMD and not just the coreboot'ed ones,
but maybe only a few people are using AMD laptop with xen so nobody noticed it
Best regards,
Mike Banon
On Thu, Apr 11, 2019 at 2:47 AM awokd <aw...@danwin1210.me> wrote:
>
> awokd wrote on 4/10/19 8:50 PM:
>
> > Got my build environment going, but I think I am missing a step. I edit
> > /home/user/qubes-builder/chroot-dom0-fc25/home/user/rpmbuild/BUILD/xen-4.8.5/xen/arch/x86/acpi/power.c
> > with the above patch. Then I run "make vmm-xen". Then I see it has
> > overwritten my change and the code is no longer commented out. What am I
> > doing wrong?
>
> Never mind, forgot I had noted this down a while back:
>
> cd /home/user/qubes-builder
> sudo chroot chroot-dom0-fc25
> su user
> cd ~
> make -C rpmbuild/BUILD/xen-4.8.5/xen
>
> Then copy from the chroot's
> home/user/rpmbuild/BUILD/xen-4.8.5/xen/xen.{gz,efi} .
>
> For some reason closing & opening the lid doesn't do anything any more.
> Don't understand what that section of code would have to do with it.
> However, if I choose Suspend from the menu, and then hit a key it
> successfully resumes! Thank you, that is very interesting. It would be
> good to figure out what's broken and upstream the fix...
>
>
--
You received this message because you are subscribed to the Google Groups
"qubes-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to qubes-users+unsubscr...@googlegroups.com.
To post to this group, send email to qubes-users@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/qubes-users/CAK7947n3X6BCwQKrMGm968F4DG7Lnqdr8cXG8ue43BVXG3RC0Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
