Steevee28 wrote: > Thank you for having a closer look. > As I already posted before (see post '#52' > (https://forums.slimdevices.com/showthread.php?111650-Spontaneous-turning-on&p=967027&viewfull=1#post967027)), > a quick code review revealed several pieces of Jive code that are not > timer-wrapping-aware. This causes events to no longer fire and > delay/wait loops to loop forever. > > Basically, all these buggy pieces of code look similar: > > Code: -------------------- > > if (timer_value > some_point_of_time) then {do something}; > > (pseudocode) -------------------- > > > To finally get that problem fixed, they all need to be reviewed and > changed to something like this: > > Code: -------------------- > > if (signed_value(timer_value - some_point_of_time) > 0) then {do something}; > > (pseudocode) -------------------- > > > I actually did have a look into that and essentially all of bits of code I examined don't really use the value itself (which would be pointless anyway as it does not reference any 'real' time that would mean anything to a user) but are about calculating a time difference that should not be affected by negative numbers being fed to it. e.g. `-111 - (-110)` still results in a valid result of positive 1 and really the only bad thing I can imagine happening here would be something like `(-MAX+4) - (MAX-3)` which results in -2*MAX + 7, but I would not expect this to happen consistently with every roll-over.
I do think someone mentioned having disabled watchdog and the UI becoming unresponsive after the critical time? That does sound consistent with my finding that the `ui` task is no longer being called several seconds before watchdog causes the player to reboot. It will be interesting to know if any of the other functions seize at that point as well, in particular the alsa backend which appears to be the reason that this clock method is being used. ------------------------------------------------------------------------ gordonb3's Profile: http://forums.slimdevices.com/member.php?userid=71050 View this thread: http://forums.slimdevices.com/showthread.php?t=111650 _______________________________________________ Radio mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/radio
