On 2012-05-30 13:24, George Papadatos wrote:
> Thanks to both of you.
>
> I do not know how to check for the PG_VERSION_NUM. I tried to edit to 
> guc.c by removing the conditional check of the PG_VERSION but with the 
> same results:
> Adrian, is this what you meant?
>
>   DefineCustomRealVariable(
>                            "rdkit.tanimoto_threshold",
>                            "Lower threshold of Tanimoto similarity",
>                            "Molecules with similarity lower than 
> threshold are not similar by % operation",
> &rdkit_tanimoto_smlar_limit,
>                            0.5,
>                            0.0,
>                            1.0,
>                            PGC_USERSET,
>                            0,
>                            (GucRealCheckHook)TanimotoLimitAssign,
>                            NULL,
>                            NULL
>                            );
>
>   DefineCustomRealVariable(
>                            "rdkit.dice_threshold",
>                            "Lower threshold of Dice similarity",
>                            "Molecules with similarity lower than 
> threshold are not similar by # operation",
> &rdkit_dice_smlar_limit,
>                            0.5,
>                            0.0,
>                            1.0,
>                            PGC_USERSET,
>                            0,
>                            (GucRealCheckHook)DiceLimitAssign,
>                            NULL,
>                            NULL
>                            );
>
> Regards,
>
> George

Hi George,

I just tried the same on my VM, with no change for the better either. My 
version of guc.c now looks like this:

static void
initRDKitGUC()
{
   if (rdkit_guc_inited)
     return;

   DefineCustomRealVariable(
                            "rdkit.tanimoto_threshold",
                            "Lower threshold of Tanimoto similarity",
                            "Molecules with similarity lower than 
threshold are not similar by % operation",
&rdkit_tanimoto_smlar_limit,
                            0.5,
                            0.0,
                            1.0,
                            PGC_USERSET,
                            0,
//if PG_VERSION_NUM >= 90100
                            (GucRealCheckHook)TanimotoLimitAssign,
                            NULL,
//else
//                           TanimotoLimitAssign,
//endif
                            NULL
                            );

   DefineCustomRealVariable(
                            "rdkit.dice_threshold",
                            "Lower threshold of Dice similarity",
                            "Molecules with similarity lower than 
threshold are not similar by # operation",
&rdkit_dice_smlar_limit,
                            0.5,
                            0.0,
                            1.0,
                            PGC_USERSET,
                            0,
//if PG_VERSION_NUM >= 90100
                            (GucRealCheckHook)DiceLimitAssign,
                            NULL,
//else
//                           DiceLimitAssign,
//endif
                            NULL
                            );

   rdkit_guc_inited = true;
}

Did a cartridge "make clean", "make", "sudo make install", and it still 
fails for me with

postgres=# create extension rdkit;
FATAL:  failed to initialize rdkit.tanimoto_threshold to 0.5
FATAL:  failed to initialize rdkit.tanimoto_threshold to 0.5
The connection to the server was lost. Attempting reset: Succeeded.
postgres=#

Cheers
-- Jan

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Rdkit-discuss mailing list
Rdkit-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rdkit-discuss

Reply via email to