Yep, basically. The SCMTool can just handle diffs for now (and you'll probably want to introduce functionality to post-review as well for generating them and posting them), and down the road you can perhaps have it query the server as well.
The one thing to note is that diffs generally don't have enough information to fetch the files from the repository. It needs to contain revision information. If your native differ for Synergy does not support this, you'll need to generate them manually in post-review and require using that tool (we require this for Perforce and other systems). You'll also need to parse this information out in the SCMTool. Look at scmtools/svn.py and the other files for an example on this. It's not a whole lot of work generally. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Fri, Sep 26, 2008 at 12:09 PM, Lasse Salmela <[EMAIL PROTECTED]>wrote: > > Thanks for the reply. In the mean while I was playing with reviewboard > using Subversion. I created some review requests manually with diffs > containing differences from several files and found that it would > probably be sufficient for me at this point (to get things started). > In case I'll only be submitting review requests manually, do I > essentially just need to create a new SCMTool for Synergy CM to be > able to use reviewboard with it? > > Thank you, > Lasse > > On Sep 25, 5:44 pm, "Christian Hammond" <[EMAIL PROTECTED]> wrote: > > I'd have to have a better understanding of tasks before I could give you > a > > clear answer. They sort of sound similar to Perforce changesets, if I'm > not > > mistaken. In a Perforce changeset, you have a bunch of metadata (summary, > > description, etc) and associated files, which all gets committed at once. > > > > If tasks are like that, then it shouldn't be a problem. > > > > Christian > > > > -- > > Christian Hammond - [EMAIL PROTECTED] > > VMware, Inc. > > > > > > > > On Thu, Sep 25, 2008 at 8:27 AM, Lasse <[EMAIL PROTECTED]> wrote: > > > > > Hello, > > > > > I'm trying to find out if I could use reviewboard with Synergy CM. > > > Before starting to look at any required SCMTool implementation, I > > > wanted to confirm one thing. > > > > > Since Synergy CM has a task based approach for tracking things instead > > > of file based (as opposed to CVS or SVN and such) is that going to be > > > a problem with how code review process in reviewboard works? > > > > > "Task" in Synergy CM represents a logical change to code and it can > > > contain several files. So from code review point of view we'd have to > > > first check in the task and then review the entire contents of the > > > task at once instead of reviewing just one file at a time. > > > > > Thanks, > > > Lasse- Hide quoted text - > > > > - Show quoted text - > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
