I am using Perforce.
The error is with tga files.

Here goes the

>>> diff -urNp c:\docume~1\marcosp\locals~1\temp\tmpixwwab 
>>> c:\docume~1\marcosp\locals~1\temp\tmpsanrqb
Traceback (most recent call last):
  File "C:\project\branches\post-review.py", line 1601, in ?
    main(sys.argv[1:])
  File "C:\project\branches\post-review.py", line 1572, in main
    diff, parent_diff = tool.diff(args)
  File "C:\project\branches\post-review.py", line 935, in diff
    m = re.search(r'(\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d)', dl[1])
IndexError: list index out of range:


On Oct 7, 8:35 pm, Chris Clark <[EMAIL PROTECTED]> wrote:
> On 10/7/2008 8:24 AM, Marcos wrote:
>
>
>
> > Post-review does not seem to like diffs in binary files, I was
> > wondering why even try do diff them.
> > So I did some changes on post-review to use a ignore_extensions.
> > So before processing a file, I did this:
>
> >             ignore_extension_found = False
> >             for extension in ignore_extensions:
> >                 find_return = depot_path.find(extension)
> >                 if find_return != -1:
> >                     debug("Ignored file %s" % depot_path)
> >                     ignore_extension_found = True
> >                     break
> >             if ignore_extension_found:
> >                 continue
>
> > Just thought on posting it here, in case someone else needs it.
>
> Could you post the error(s) you get without the change? I'm successfully
> using post review with binary files (in that they are marked as binary
> and they are not diff'd in the diffviewer). I suspect it depends on the
> SCM in use.
>
> Chris
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to