hey , thanks for the code you but out
but i cant seem to make it work it keeps telling me ignore_extensions
is not defined
do i have to define it else where, and can you tell me what line did
you but this in?

Thanks

On Oct 7, 11:24 am, Marcos <[EMAIL PROTECTED]> wrote:
> Post-review does not seem to like diffs in binary files, I was
> wondering why even try do diff them.
> So I did some changes on post-review to use a ignore_extensions.
> So before processing a file, I did this:
>
>             ignore_extension_found = False
>             for extension in ignore_extensions:
>                 find_return = depot_path.find(extension)
>                 if find_return != -1:
>                     debug("Ignored file %s" % depot_path)
>                     ignore_extension_found = True
>                     break
>             if ignore_extension_found:
>                 continue
>
> Just thought on posting it here, in case someone else needs it.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to