Thanks for pointing out that the diff viewer is not the right place
for tracking changes and discussions.
I understand that tracking comments across revisions is difficult.
However, I was asking because some of the commercial review tools
provide such functionality.
If it is recommended to use mainly the review request page I have
another first-time user question: Would it be possible to show more
code context on this page? One line of code is fairly small in the
context of a big review session.
On Aug 7, 10:37 pm, Christian Hammond <chip...@chipx86.com> wrote:
> Hi Philipp,
> All the discussion on a series of changes takes place on the review
> request's page. You shouldn't really use the diff viewer for this. Migrating
> comments across revisions of a diff is incredibly hard and impossible to do
> successfully, consistently. You can't guarantee the lines will match up in
> any way, and you could end up dropping comments or moving them onto the
> wrong lines. They also might just be irrelevant.
> We don't have any plans at all to even attempt something like this, as
> that's really what the review request page is for. You can see a timeline of
> all the reviews, the affected code, and you can always click on the header
> for the block of code to jump to the right place in the diff.
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com
> On Fri, Aug 7, 2009 at 6:29 AM, Philipp Henkel
> > Hello,
> > I'm new to Review Board and I would like to use it in combination with
> > Perforce and post-review.
> > There seems to be no strong connection of comments and code changes.
> > In Diff View comments seem to be bound to single diffs. When you add a
> > new diff it is difficult to match old comments and new changes because
> > you don't see the previous comments. Questions like "Is every issue
> > addressed?" or "What is the reason for that change?" cannot be
> > answered immediately. You always have to go back to one of the
> > previous diffs and search for the discussion.
> > Our current review work flow is like this:
> > 1. Create new request: add a large diff using post-review (might be a
> > complete new feature)
> > 2. Reviewer and Coder add comments to this diff
> > 3. Coder applies changes and adds an updated diff using post-review
> > 4. Reviewer is satisfied -> go to 5 or next iteration is started ->
> > go to 2.
> > 5. Review done
> > I know that RB is optimized for pre-commits and I assume that those
> > pre-commits reviews tend to be much smaller than post-commits ones.
> > However, perhaps there is a simple solution to my problem if I
> > slightly change the work flow. Did I overlook something? Is it
> > possible to show older comments in the latest diff? Would this be a
> > nice feature?
> > Best regards,
> > Philipp
You received this message because you are subscribed to the Google Groups
To post to this group, send email to firstname.lastname@example.org
To unsubscribe from this group, send email to
For more options, visit this group at