Hi, Certainly modifying the code would work as a short-term solution. You could either figure out how to disable this in Pygments (I believe it requires modifying a file and then "re-compiling" all the lexer definitions or registrations down into something), or you could disable it in Review Board by modifying apply_pygments() in reviewboard/diffviewer/diffutils.py. It should be somewhat obvious what you'll need to do.
Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, Aug 24, 2009 at 7:07 AM, Dick Wall <dickw...@gmail.com> wrote: > > Hi Christian > > I suspected it was caused by the syntax highlighter, and I did indeed > disable that and it worked fine. I have it turned off for now, but > it's a shame because 90% or more of our code reviews are Java. Anyway, > it should be real easy to reproduce - so far none of the scala code > reviews are displaying - the python process just pegs one of the cores > and stays there indefinitely requiring lighthttpd to be killed and > restarted. I am guessing that any attempt to use pygments to color > scala code will produce the same results (at least any non-trivial > scala class). I might see if I can find a way to ignore scala in the > pygments source code though, now that I know what is used :-). > > Thanks for the help. > > Dick > > On Aug 19, 12:49 pm, Christian Hammond <chip...@chipx86.com> wrote: > > Hi, > > > > A likely cause might be a bug in the Pygments syntax highlighter. Try > > disabling syntax highlighting and load the diff again. If it comes up, > then > > we need to talk to the Pygments guys and report this. > > > > Sorry this is causing you guys problems. There's no good short-term > solution > > for disabling the syntax highlighting for just this language. We do have > > someone working from time to time on more configurable syntax > highlighting > > control though, which will eventually give this... > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.review-board.org > > VMware, Inc. -http://www.vmware.com > > > > > > > > On Wed, Aug 19, 2009 at 11:41 AM, Dick Wall <dickw...@gmail.com> wrote: > > > > > Hi Folks > > > > > We are very happily running reviewboard 1.0 at work, using lighthttpd > > > (although I suspect that doesn't actually affect this problem, but I > > > mention it just in case). It works flawlessly for all file types > > > except Scala, which we have recently started using/committing. > > > > > The problem is that when trying to view the differences in a changeset > > > with scala files in it, the python appears to go into a CPU intensive > > > infinite loop (my guess is probably trying to parse the scala well > > > enough to do some syntax coloring or something). Has anyone else seen > > > this (is anyone else using it for Scala diffs?) and can anyone point > > > me to a fix (like, is it easy to disable syntax coloring attempts just > > > for .scala files)? > > > > > I am about to try 1.0.1 since I see that has been released, but I > > > don't see anything in the list of bug fixes that might address this, > > > so I thought I would put a feeler out here as well. > > > > > Thanks > > > > > Dick > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to firstname.lastname@example.org To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---