Awesome, works great with the full lenght SHA1s. Thanks for the help. I will close out the bug with a note.
-- Sean On Jan 2, 1:08 pm, Christian Hammond <chip...@chipx86.com> wrote: > Hi, > > I believe the problem is short SHA1s vs. full-length SHA1s. GitHub requires > a full-length SHA1 in the diff files, whereas Git by default generates a > short SHA1. > > You have two options: > > 1) Run `git diff --full-index` > > 2) Run post-review --output-diff > > Try that and upload the diff. It should work :) > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Sat, Jan 2, 2010 at 12:33 PM, splaice <spla...@gmail.com> wrote: > > Hello, > > I too am using the latest nightly with a github private repo with > > great success using post-review. Though I think I found a bug/problem > > with using the new review request submission via the web interface > > with a diff. > > > I have created an issue for this problem at > >http://code.google.com/p/reviewboard/issues/detail?id=1448. > > > If there is anything I can do to help debug let me know. > > -- > > Sean > > > On Dec 27 2009, 7:33 am, "mik...@larkfarm.com" <larkw...@gmail.com> > > wrote: > > > Replying to myself to document what actually worked. I do NOT > > > guarantee that this is the best way, but: > > > > sudo easy_install -vhttp:// > > downloads.reviewboard.org/nightlies/ReviewBoard-1.1alpha2.dev_... > > > > Until I did that, RB was stubbornly stuck on the 1.1 alpha, not on a > > > nightly. > > > > Mike > > > > On Dec 23, 12:48 pm, Mike Gunderloy <larkw...@gmail.com> wrote: > > > > > Aha, I don't even see "GitHub (Private)". So I'd guess that somewhere I > > missed a step in getting a nightly running. > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~----------~----~----~----~------~----~------~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegr > > oups.com> > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en