What I found is that if I do not change post-review.py script at all, I can post the review but I can not post the diff.
kapar...@ltsdo-kaparikh ~ $ post-review.cygwin 275221 -d This tool looks at the given Pending-CL# & posts it for review. [Version: 200911 13_1141] >>> Repository info 'Path: pf-sj1-mob.sj.broadcom.com:1668, Base path: None, Sup ports changesets: True' >>> Generating diff for changenum 275221 >>> P4CLIENT is LTSDO-KAPARIKH >>> status is pending >>> Lines are: ['//depot/Sources/Integration/Automation_Scripts/CCB_CQ_Analysis/ ccb_cq_analysis.pl#5 - edit change 275221 (text) by kapar...@ltsdo- KAPARIKH\r\n' ] >>> Client LTSDO-KAPARIKH depot path //depot/Sources/Integration/Automation_Scri pts/CCB_CQ_Analysis/ccb_cq_analysis.pl >>> Writing "//depot/Sources/Integration/Automation_Scripts/CCB_CQ_Analysis/ccb_ cq_analysis.pl#5" to "/cygdrive/c/Temp/tmpE2AEBQ" >>> Old file: /cygdrive/c/Temp/tmpE2AEBQ New file c:/Perforce/sysrel_scripts/CCB _CQ_Analysis/ccb_cq_analysis.pl >>> Attempting to create review request for 275221 repository path pf-sj1-mob.sj.broadcom.com:1668 >>> HTTP POSTing to http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/n ew/: {'repository_path': 'pf-sj1-mob.sj.broadcom.com:1668', 'changenum': '275221 '} >>> Review request created >>> --- c:\Perforce\sysrel_scripts\CCB_CQ_Analysis\ccb_cq_analysis.pl //depot/ Sources/Integration/Automation_Scripts/CCB_CQ_Analysis/ ccb_cq_analysis.pl#5 +++ c:\Perforce\sysrel_scripts\CCB_CQ_Analysis \ccb_cq_analysis.pl 2010-04- 29 09:57:09 @@ -13,7 +13,16 @@ use Win32::OLE::Const 'Microsoft Excel'; $Win32::OLE::Warn = 3; # die on errors... use Tie::File; ####################################################################### -#All Variables declaration >>> Uploading diff >>> HTTP POSTing to http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/5 4/diff/new/: {} Error uploading diff: One or more fields had errors (105) Your review request still exists, but the diff is not attached. On Apr 28, 5:11 pm, Christian Hammond <[email protected]> wrote: > It should work with https fine. I use it with https every day. Can you paste > the output when using --debug with post-review? > > Christian > > -- > Christian Hammond - [email protected] > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > > > On Wed, Apr 28, 2010 at 4:23 PM, Kunjal <[email protected]> wrote: > > Here is the scenairo happening. > > We are using post-review.py file to post review. > > We close down HTTP port and open up HTTPS port. > > Now, when I post the review, I can not post review at all !! > > What I ovserve that in post-review.py, there are HTTP post methods are > > used and > > methonds like: self.http_post, http_get etc. are used. > > > Do we have post-review.py which supports HTTPS? > > > Thanks > > Kunjal > > > On Apr 27, 10:59 pm, Christian Hammond <[email protected]> wrote: > > > Review Board doesn't know or care anything about http vs. https. If > > you're > > > having issues with post-review, I suspect it's due to your existing > > > configuration referencing the http URL, which presumably doesn't work > > now. I > > > don't know how you have it configured, so it may be post-review.py, or a > > > .reviewboardrc, or a property on the repository. > > > > Christian > > > > -- > > > Christian Hammond - [email protected] > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Tue, Apr 27, 2010 at 10:57 PM, Kunjal <[email protected]> > > wrote: > > > > Chris, > > > > > Changes to Apache installation is done and we have moved our RB > > > > website to HTTPS. > > > > However, now when I post the review now, I can not post the diff. > > > > Does the HTTPS interact the way diff is done ? > > > > Do I need to update post-review.py script to update the url field to > > > > point to https? > > > > > Thanks a lot. > > > > Kunjal > > > > > On Apr 27, 10:45 pm, Christian Hammond <[email protected]> wrote: > > > > > Do you mean the Apache installation? That should work fine. Review > > Board > > > > > doesn't really care whether it's being used with https or http. It's > > a > > > > > matter of configuring your Apache installation and updating your > > > > > .reviewboardrc files (or whatever mechanism you're using for > > post-review > > > > > support) to point to the https URL instead of the http URL. > > > > > > Christian > > > > > > -- > > > > > Christian Hammond - [email protected] > > > > > Review Board -http://www.reviewboard.org > > > > > VMware, Inc. -http://www.vmware.com > > > > > > On Tue, Apr 27, 2010 at 5:38 PM, Kunjal <[email protected]> > > wrote: > > > > > > We have RB 1.0.5.1 in production and it is http now. > > > > > > We want to move it to https. > > > > > > So, we did apache server settings and move RB to https. > > > > > > But now I can post the review but I can not post the diff. > > > > > > It gives me error. > > > > > > Is HTTTPS supported in 1.0.5.1? > > > > > > > Because I see that in the roadmap of RB 1.5, it says ... > > > > > > > SSH and HTTPS support -- commited. > > > > > > > Thanks > > > > > > Kunjal > > > > > > > -- > > > > > > Want to help the Review Board project? Donate today at > > > > > >http://www.reviewboard.org/donate/ > > > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > > > -~----------~----~----~----~------~----~------~--~--- > > > > > > To unsubscribe from this group, send email to > > > > > > [email protected]<reviewboard%2bunsubscr...@googlegroups.com> > > <reviewboard%2bunsubscr...@googlegroups.com> > > > > <reviewboard%2bunsubscr...@googlegr oups.com> > > > > > > For more options, visit this group at > > > > > >http://groups.google.com/group/reviewboard?hl=en > > > > > > -- > > > > > Want to help the Review Board project? Donate today athttp:// > > > >www.reviewboard.org/donate/ > > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > > -~----------~----~----~----~------~----~------~--~--- > > > > > To unsubscribe from this group, send email to > > > > [email protected]<reviewboard%2bunsubscr...@googlegroups.com> > > <reviewboard%2bunsubscr...@googlegroups.com> > > > > > For more options, visit this group athttp:// > > > > groups.google.com/group/reviewboard?hl=en > > > > > -- > > > > Want to help the Review Board project? Donate today at > > > >http://www.reviewboard.org/donate/ > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > -~----------~----~----~----~------~----~------~--~--- > > > > To unsubscribe from this group, send email to > > > > [email protected]<reviewboard%2bunsubscr...@googlegroups.com> > > <reviewboard%2bunsubscr...@googlegroups.com> > > > > For more options, visit this group at > > > >http://groups.google.com/group/reviewboard?hl=en > > > > -- > > > Want to help the Review Board project? Donate today athttp:// > >www.reviewboard.org/donate/ > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > -~----------~----~----~----~------~----~------~--~--- > > > To unsubscribe from this group, send email to > > [email protected]<reviewboard%2bunsubscr...@googlegroups.com> > > > For more options, visit this group athttp:// > > groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > > > - Show quoted text - > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~----------~----~----~----~------~----~------~--~--- > > To unsubscribe from this group, send email to > > [email protected]<reviewboard%2bunsubscr...@googlegroups.com> > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today > athttp://www.reviewboard.org/donate/ > Happy user? Let us know athttp://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group > athttp://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
