You know, it's a good question. We do it by default regardless of the code path, in order to verify that the repository was correctly set up. Maybe we want to revisit that, though I need to think more about it.
Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Jan 18, 2011 at 9:26 PM, NicBinkley <nbink...@vmem.com> wrote: > Thanks for the assistance. > > I upgraded to 1.5.2 and was able to get the GIT repositories setup in > conjunction with SSH keys. > > I'm still confused as to why ReviewBoard needs git style access when > it's setup to use gitweb URLs. > > > > > On Jan 11, 12:59 pm, Christian Hammond <chip...@chipx86.com> wrote: > > Hi, > > > > The http one is just an example. I'll give you a real-world example. > http://reviews.reviewboard.orguses the following for our Review Board > > Git repo: > > > > Path: git://github.com/reviewboard/reviewboard.git > > Mirror Path: g...@github.com:reviewboard/reviewboard.git > > Raw file URL mask: > http://github.com/api/v2/yaml/blob/show/reviewboard/reviewboard/<revision> > > > > The problem in your case is that it's backed by SSH, and you likely > > don't have a proper key setup that Review Board can access. > > > > We just put out the 1.5.2 release, which does a lot to make this > > clearer. It provides a more meaningful error when it's hitting key > > issues with SSH, and it fixes authentication issues (sometimes leading > > to "repository not found" errors) due to some parsing problems. It > > also provides SSH key management (admin UI -> Settings -> SSH), > > allowing you to create a brand new SSH key for your RB setup (you can > > then use the public key provided after creation) to allow access on > > the server end. Or you can upload an existing private key for RB to > > use. > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > > > > > > > > > > > > > > On Tue, Jan 11, 2011 at 10:47 AM, NicBinkley <nbink...@vmem.com> wrote: > > > thanks for the reply but something still isn't jiving with our setup. > > > > > Installation information: > > > ReviewBoard - version 1.5.1 > > > GIT and GITWeb - version 1.7.0.4 > > > We're using gitosis to control access to the repositories. > > > > > Your example shows an http address for the path - does that mean that > > > ReviewBoard expects the GIT repositories to be available via http? > > > > > We don't have http access to the repos so I tried setting the path to: > > >http://path/to/gitweb?p=repo.git (the base gitweb address) > > > That results in: A repository was not found at the specified path. > > > > > Our origin URL, as shown by 'git remote show origin', is: > > > gitosis@gitserver:repo.git > > > Putting that in the Path results in the same not found at specified > > > path error. > > > > > Maybe I should start by asking what requirements ReviewBoard has in > > > regards to GIT installations. > > > Does it need http access to the repositories? > > > Does it need non-authenticated file access? > > > Will it work when repositories are available only via SSH key > > > authentication and GITWeb? > > > > > Thanks. > > > > > On Jan 10, 11:00 pm, Christian Hammond <chip...@chipx86.com> wrote: > > >> Hi, > > > > >> First off, can you tell me which version of Review Board you're using? > > > > >> Perhaps the documentation is misleading, but what you should be doing > > >> is setting Path to be the "origin" URL. Review Board will use Path to > > >> attempt to match the repository provided by post-review (which it gets > > >> from doing 'git remote show origin'). If you point it to a local URL, > > >> it will try to access it, but if you otherwise use a remote URL, it > > >> won't try and instead will use the raw URL that was set. > > > > >> So you'd want: > > > > >> Path:http://git.example.com/blah/blah/blah.git > > >> Raw URL:http://path/to/gitweb/with<file>and<revision> > > > > >> Does that help? > > > > >> Christian > > > > >> -- > > >> Christian Hammond - chip...@chipx86.com > > >> Review Board -http://www.reviewboard.org > > >> VMware, Inc. -http://www.vmware.com > > > > >> On Mon, Jan 10, 2011 at 6:04 PM, NicBinkley <nbink...@vmem.com> > wrote: > > >> > I am attempting to setup ReviewBoard to use our GIT repositories on > > >> > another server via GitWeb. > > > > >> > The issue I'm running into is that I cannot complete the ReviewBoard > > >> > repository setup UNLESS there is a valid local copy of the GIT repo > on > > >> > the same server. It will error out when clicking save if the Path > is > > >> > either not set or set to a "dummy" .git directory. > > > > >> > All the instructions I've found say that the "Path" is not > needed/used > > >> > if the "RAW file url mask" is set. > > > > >> > What did work is cloning the repo to the ReviewBoard server and then > > >> > complete the setup using that path as the Path variable but that > seems > > >> > counter-intuitive to what I want (which is for ReviewBoard to use > the > > >> > GitWeb URL). > > > > >> > Is this expected behavior? i.e. is an initial valid repository > > >> > required only for setup purposes but after that it's never used? > > > > >> > Here's a breakdown of what was tried: > > > > >> > Attempt one: Failed. It also triggered django failure email to > root > > >> > @ localhost > > >> > Hosting Service: Custom > > >> > Repository Type: git > > >> > Path: <blank> > > >> > Mirror Path: <blank> > > >> > RAW File Url mask:http://path/to/gitweb/with<file>and<revision> > > > > >> > Attempt two: Failed with: <django.utils.functional.__proxy__ object > > >> > at 0x2ad39488e510> > > >> > Hosting Service: Custom > > >> > Repository Type: git > > >> > Path: /path/to/dummy_repository > > >> > Mirror Path: <blank> > > >> > RAW File Url mask:http://path/to/gitweb/with<file>and<revision> > > > > >> > Attempt Three: worked > > >> > Hosting Service: Custom > > >> > Repository Type: git > > >> > Path: /path/to/valid/repository/.git > > >> > Mirror Path: <blank> > > >> > RAW File Url mask:http://path/to/gitweb/with<file>and<revision> > > > > >> > -- > > >> > Want to help the Review Board project? Donate today athttp:// > www.reviewboard.org/donate/ > > >> > Happy user? Let us know athttp://www.reviewboard.org/users/ > > >> > -~----------~----~----~----~------~----~------~--~--- > > >> > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > > >> > For more options, visit this group athttp:// > groups.google.com/group/reviewboard?hl=en > > > > > -- > > > Want to help the Review Board project? Donate today athttp:// > www.reviewboard.org/donate/ > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > -~----------~----~----~----~------~----~------~--~--- > > > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > > > For more options, visit this group athttp:// > groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
