Hi Gonzalo, Nothing specifically. These problems are a result of inconsistencies in encodings between source code checkout, editor, repository, and database. Our code expects that everything can end up in UTF-8, and we'll render as that. We store the uploaded patch in such a way where the encoding is preserved and attempt to patch exactly what we get from the server with that patch.
If the file coming from the server is in a different encoding than the patched file, then one of those should be fixed. If all files on the server are in a known encoding that we don't detect properly, you can try to set the Encoding field for the repository. Otherwise it's really just a matter of being consistent in what developers are encoding as. Christian On Jul 18, 2012, at 12:51, Gonzalo Arce <[email protected]> wrote: > Hello Christian, > > This sounds like exciting news, I was wondering if there is gonna be any bug > fixes regarding foreign characters (like "รก") triggering an error in the Diff > Viewer? > > Thanks so much for all your efforts on this great software. > > Regards, > > 2012/7/18 Christian Hammond <[email protected]> > Hi Stephen, > > I'll do what I can to make that deadline. Please hound me about it as it gets > closer in case we slip :) > > Christian > > -- > Christian Hammond - [email protected] > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > > On Wed, Jul 18, 2012 at 12:21 PM, Stephen Gallagher > <[email protected]> wrote: > On Wed, 2012-07-18 at 12:15 -0700, Christian Hammond wrote: > > > > So here's the current plan. 1.6.10 will be happening over the next few > > days. I have a bug to fix with extensions and a couple changes to > > still get in for 1.7, but I'll shoot for a beta this weekend. I'd like > > to follow with an RC in the next month and a release shortly after. > > This will depend on quality (and some deadlines I have elsewhere), but > > I'd like us to be standardizing on 1.7 very soon, as there are some > > amazing changes in it. > > > Hey, that's fantastic! That will line up well with the Fedora schedule. > We're going alpha (features must be testable) on August 7th and then > beta (features should be ready for release) on October 2nd. So it sounds > like I'll be able to get ReviewBoard into F18 after all. > > I was a little concerned I would have to pull RB out of Fedora 18, > because it's shipping with Django 1.4, on which ReviewBoard 1.6 cannot > run. > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
