Hi Christian, We have three buttons on comment box: major, minor, info. for that we need to do change in the reviews.js
As asked buy you I have installed jsmin and lessc. But lessc requires "node" I guess, because its throwing error. bash-3.2$ cd less.js/ bash-3.2$ make node test/less-test.js make: node: Command not found make: *** [test] Error 127 bash-3.2$ I tried installing node but getting some issue, do I need to install some specific version ? After installing node, I will be ready for packaging right ? Can you please eleborate the process of './setup.py bdist_egg release' . Do I need to do this in my workspace from where the application is running ? Regards, Satish On Thursday, 16 May 2013 14:56:06 UTC+5:30, Christian Hammond wrote: > > Hi Satish, > > reviews.*.min.js is built as part of the packaging process. You'd have to > modify the reviews.js in the source tree, then run './setup.py bdist_egg > release' in order to get a reviews.*.min.js file that the browser will use. > You will then need to install that package and re-upgrade your site. > > This will require all the dependencies we use for building Review Board, > including lessc and jsmin. > > Note that this process will change a bit in future versions, and > reviews.js is being actively rewritten from scratch and ported out to a new > set of files. > > What kind of modifications are you making? > > Christian > > -- > Christian Hammond - chi...@chipx86.com <javascript:> > Review Board - http://www.reviewboard.org > Beanbag, Inc. - http://www.beanbaginc.com > > On May 16, 2013, at 2:19 AM, satish singh <triv...@gmail.com <javascript:>> > wrote: > > Hi David, > We are migrating from RB1.6.3 to RB1.7.7.1, We were successful in > deploying RB1.7.7.1 with mod_wsgi on apache server. > We have some of our specific code in RB, which I merged on RB1.7.7.1, its > working fine and picking up the chnages, only changes to JS file > like reviews.js is not getting reflected, I saw application is using > reviews.min.js and review.js is included in it. But the changes of > review.js is not reflecting in review.min.js. I tried restarting the > server, cleaning the browser cache but nothing has worked for me. > > How changes to JS file can be included in its minified file ? Do I need to > run some command ? > > Regards, > Satish Singh > > On Thursday, 16 May 2013 04:51:33 UTC+5:30, David Trowbridge wrote: >> >> Can you clarify a bit how you're doing your deployments? The .min.js >> files are built as part of the packaging step. >> >> -David >> >> >> On Wed, May 15, 2013 at 3:45 AM, satish singh <triv...@gmail.com> wrote: >> >>> Anyone please provide some input on this ? >>> >>> >>> On Wednesday, 15 May 2013 15:15:16 UTC+5:30, satish singh wrote: >>>> >>>> Hi Team, >>>> >>>> I have made changes to review.js, but its not reflecting in >>>> review.min.js. >>>> >>>> I can see this setting in setting.py: >>>> >>>> 'reviews': { >>>> 'source_filenames': ( >>>> # Note: These are roughly in dependency order. >>>> 'rb/js/models/**abstractCommentBlockModel.js', >>>> 'rb/js/models/**abstractReviewableModel.js', >>>> 'rb/js/models/**commentIssueManagerModel.js', >>>> 'rb/js/models/**fileAttachmentCommentBlockMode**l.js', >>>> 'rb/js/models/**fileAttachmentReviewableModel.**js', >>>> 'rb/js/models/**regionCommentBlockModel.js', >>>> 'rb/js/models/**imageReviewableModel.js', >>>> 'rb/js/models/**screenshotCommentBlockModel.**js', >>>> 'rb/js/models/**screenshotReviewableModel.js', >>>> 'rb/js/views/**abstractCommentBlockView.js', >>>> 'rb/js/views/**abstractReviewableView.js', >>>> 'rb/js/views/**fileAttachmentCommentBlockView**.js', >>>> 'rb/js/views/**fileAttachmentReviewableView.**js', >>>> 'rb/js/views/**issueSummaryTableView.js', >>>> 'rb/js/views/**regionCommentBlockView.js', >>>> 'rb/js/views/**imageReviewableView.js', >>>> 'rb/js/diffviewer.js', >>>> 'rb/js/reviews.js', >>>> ), >>>> 'output_filename': 'rb/js/reviews.min.js', >>>> >>>> Please any one who can let me know, how to make my changes in >>>> reviews.js, included in reviews.min.js ? >>>> >>> >>> -- >>> Want to help the Review Board project? Donate today at >>> http://www.reviewboard.org/donate/ >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> -~----------~----~----~----~------~----~------~--~--- >>> To unsubscribe from this group, send email to >>> reviewboard...@googlegroups.com >>> For more options, visit this group at >>> http://groups.google.com/group/reviewboard?hl=en >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/groups/opt_out. >>> >>> >>> >> >> > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard...@googlegroups.com <javascript:> > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard...@googlegroups.com <javascript:>. > For more options, visit https://groups.google.com/groups/opt_out. > > > > > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
