Hi,

I've just installed 1.7.8.1 and confirmed that the problem no longer
exists. Thanks for the quick turn around!

Adam


On 3 June 2013 13:42, Christian Hammond <chip...@chipx86.com> wrote:

> Thanks for pointing this out. Not sure how our unit tests didn't catch it,
> but your fix is correct.
>
> I'm putting up a 1.7.8.1 and then calling it a (very late) night.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
>
> On Mon, Jun 3, 2013 at 3:19 AM, adam.coll...@gmail.com <
> adam.coll...@gmail.com> wrote:
>
>> Just to add, I have deployed a temporary work around of changing the
>> lines to read
>>
>>         service = get_hosting_service(hosting_type)
>>         if not service or service.self_hosted:
>>
>> I'm not convinced that this is a suitable patch for including upstream,
>> so have avoided posting a review request on reviews.reviewboard.org -
>> I'm happy to help with such a diff if given a little direction though :)
>>
>> Adam
>>
>>
>> On 3 June 2013 12:09, adam.coll...@gmail.com <adam.coll...@gmail.com>wrote:
>>
>>> Hi,
>>>
>>> I just upgraded to 1.7.8 (from 1.7.7.1) and am having problems adding
>>> new repositories/saving existing repositories.
>>>
>>> The (abridged) stack trace is:
>>>
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Django-1.4.5-py2.7.egg/django/contrib/admin/options.py",
>>> line 1037, in change_view
>>>     new_object = self.save_form(request, form, change=True)
>>>
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Django-1.4.5-py2.7.egg/django/contrib/admin/options.py",
>>> line 703, in save_form
>>>     return form.save(commit=False)
>>>
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.8-py2.7.egg/reviewboard/scmtools/forms.py",
>>> line 968, in save
>>>     assert service
>>>
>>> AssertionError
>>>
>>> All of our repositories are hosted internally and are using the "(None -
>>> Custom Repository)" hosting service. I'm guessing that that's coming back
>>> as None and failing the assert.
>>>
>>> Is commenting out the assert a viable workaround or is nulls getting in
>>> the db a bad idea?
>>>
>>> Thanks,
>>>
>>> Adam
>>>
>>>
>>> On 3 June 2013 10:14, Christian Hammond <chip...@chipx86.com> wrote:
>>>
>>>> Review Board 1.7.8 is out, and has a number of new features, bug fixes,
>>>> and performance enhancements. Too much to list, in fact. I'm just going to
>>>> direct you to the news post.
>>>>
>>>> http://www.reviewboard.org/news/2013/06/03/review-board-1-7-8-released/
>>>>
>>>> Also, as you'll notice, we have a whole new site! Let us know if you
>>>> have any trouble with it.
>>>>
>>>> Christian
>>>>
>>>> --
>>>> Christian Hammond - chip...@chipx86.com
>>>> Review Board - http://www.reviewboard.org
>>>> Beanbag, Inc. - http://www.beanbaginc.com
>>>>
>>>> --
>>>> Want to help the Review Board project? Donate today at
>>>> http://www.reviewboard.org/donate/
>>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>>> -~----------~----~----~----~------~----~------~--~---
>>>> To unsubscribe from this group, send email to
>>>> reviewboard+unsubscr...@googlegroups.com
>>>> For more options, visit this group at
>>>> http://groups.google.com/group/reviewboard?hl=en
>>>> ---
>>>> You received this message because you are subscribed to the Google
>>>> Groups "reviewboard" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>> an email to reviewboard+unsubscr...@googlegroups.com.
>>>> For more options, visit https://groups.google.com/groups/opt_out.
>>>>
>>>>
>>>>
>>>
>>>
>>  --
>> Want to help the Review Board project? Donate today at
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~----------~----~----~----~------~----~------~--~---
>> To unsubscribe from this group, send email to
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/reviewboard?hl=en
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>>
>
>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to