I've posted a patch for review at https://reviews.reviewboard.org/r/7183/ 
which should resolve this issue.



On Tuesday, April 7, 2015 at 2:18:43 PM UTC-4, Richard Parks wrote:
>
> Hi, I've used RBTools for several reviews with no problems but I've now 
> encountered a problem with a svn repository where I have moved some files 
> (deleted and added in svn)
>
> I'm running RBTools 0.7.2 and svn version 1.7.18
>
> basic error is:
> >rbt diff 12192 12208
> CRITICAL: object of type 'NoneType' has no len()
>
> running in debug:
> >rbt diff --debug 12192 12208
> >>> RBTools 0.7.2
> >>> Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit (
> Intel)]
> >>> Running on Windows-7-6.1.7601-SP1
> >>> Home = C:\Users\myusername\AppData\Roaming
> >>> Current directory = C:\subversion\myprojectname\branches\development\
> branchspecificname
> >>> Checking for a Subversion repository...
> >>> Running: svn info --non-interactive
> >>> Running: diff --version
> >>> Running: svn --version -q
> >>> repository info: Path: http://mycompanysvnrepo, Base path: 
> /branches/development/branchspecificname, Supports changesets: False
> >>> Making HTTP GET request to http://reviewboard.mycompany/api/
> >>> Running: svn log -r 12192 -l 1 --xml
> >>> Running: svn log -r 12208 -l 1 --xml
> >>> Running: svn info --non-interactive
> >>> Running: diff --version
> >>> Running: svn --version -q
> >>> repository info: Path: http://mycompanysvnrepo, Base path: 
> /branches/development/branchspecificname, Supports changesets: False
> >>> Running: svn status -q --ignore-externals
> >>> Running: svn diff --diff-cmd=diff --notice-ancestry -r 12192:12208
> ...
> >>> Running: svn info activity_monitor/src/activity_monitor_lib/hdl/
> activity_monitor_top.vhd
> >>> Running: svn info myblock/src/myblock_lib/hdl/activity_monitor.vhd
> >>> Command exited with rc 1: ['svn', 'info', u
> 'myblock/src/myblock_lib/hdl/activity_monitor.vhd']
> ["svn: warning: W155010: The node 
> 'C:\\subversion\\myproject\\branches\\development\\branchspecificname\\myblock\\src\\myblock_lib\\hdl\\activity_monitor.vhd'
>  
> was not found.\n"
> , '\n', "svn: E200009: Could not display info for all targets because 
> some targets don't exist\n"]---
> Traceback (most recent call last):
>   File "C:\Program Files 
> (x86)\RBTools\bin\..\Python27\Scripts\rbt-script.py", line 8, in <module>
>     load_entry_point('RBTools==0.7.2', 'console_scripts', 'rbt')()
>   File "C:\Program Files 
> (x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.egg\rbtools\commands\main.py"
> , line 133, in main
>     command.run_from_argv([RB_MAIN, command_name] + args)
>   File "C:\Program Files 
> (x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.egg\rbtools\commands\__init__.py"
> , line 555, in run_from_argv
>     exit_code = self.main(*args) or 0
>   File "C:\Program Files 
> (x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.egg\rbtools\commands\diff.py"
> , line 68, in main
>     extra_args=extra_args)
>   File "C:\Program Files 
> (x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.egg\rbtools\clients\svn.py"
> , line 326, in diff
>     diff = self.convert_to_absolute_paths(diff, repository_info)
>   File "C:\Program Files 
> (x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.egg\rbtools\clients\svn.py"
> , line 589, in convert_to_absolute_paths
>     info = self.svn_info(file, True)
>   File "C:\Program Files 
> (x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.egg\rbtools\clients\svn.py"
> , line 617, in svn_info
>     none_on_ignored_error=True)
>   File "C:\Program Files 
> (x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.egg\rbtools\clients\svn.py"
> , line 707, in _run_svn
>     return execute(cmdline, *args, **kwargs)
>   File "C:\Program Files 
> (x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.egg\rbtools\utils\process.py"
> , line 102, in execute
>     if split_lines and len(data) > 0:
> TypeError: object of type 'NoneType' has no len()
>
> Sorry some names and paths have been hidden for corporate reasons.
>
> Ultimately it looks like rbt is trying to do an svn diff on one of the 
> moved files 'activiy_monitor.vhd' but in it's old svn location (ie where I 
> have moved it from) so it no longer exists there.
>
> I don't think the problem is with my svn repo as I can create a svn diff 
> successfully. 
>
> Any help resolving this would be greatly appreciated. Thanks in advance.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to