Well, we should figure out what part of the diff file isn't being parsed correctly. If you're willing to jump into the code to make it save the diff so we can have a sample, we can get the bug fixed.
-David On Tue, Jun 21, 2016 at 9:04 AM Joe Cooper <joe.coo...@socketlabs.com> wrote: > I've narrowed this problem down to if the same file is modified and > renamed in the same commit, no diffs are generated for any file when > creating a review request and the 'could not be found in the repository' > error is logged. Is there a work-around for this besides not committing a > modification and rename at the same time? > > On Monday, June 20, 2016 at 2:48:08 PM UTC-4, Joe Cooper wrote: >> >> David, >> >> Thank you for your prompt feedback. >> >> I've added the error details from the log below. I the commit I had a >> problem with a file was renamed to: ''/some/path/SomeFile.cs'. I'm not sure >> why there would be a problem because the file is indeed in the repository >> at that time. Unless the python code is looking for that file in the parent >> commit? >> >> What would be the best way to resolve this? Is there an configuration >> option to ignore these types of errors so we can at least get diffs for the >> remaining files? Is there a way to avoid this type of problem? >> >> >> >> >> 2016-06-20 18:15:34,668 - ERROR - - Unable to update new review request >> from commit ID fa4e9537b44661f3d815d7b9bdbc413344f879bc: The file >> '/some/path/SomeFile.cs' (r) could not be found in the repository >> Traceback (most recent call last): >> File >> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/reviews/managers.py", >> line 150, in create >> review_request.update_from_commit_id(commit_id) >> File >> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/reviews/models/base_review_request_details.py", >> line 220, in update_from_commit_id >> self.update_from_committed_change(commit_id) >> File >> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/reviews/models/base_review_request_details.py", >> line 283, in update_from_committed_change >> base_commit_id=commit.base_commit_id) >> File >> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/diffviewer/managers.py", >> line 441, in create_from_data >> check_existence=(not parent_diff_file_contents))) >> File >> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/diffviewer/managers.py", >> line 586, in _process_files >> base_commit_id) >> FileNotFoundError: The file '/some/path/SomeFile.cs' (r) could not be >> found in the repository >> >> 2016-06-20 18:15:34,668 - ERROR - - Unable to update new review request >> from commit ID fa4e9537b44661f3d815d7b9bdbc413344f879bc: The file >> '/some/path/SomeFile.cs' (r) could not be found in the repository >> Traceback (most recent call last): >> File >> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/reviews/managers.py", >> line 150, in create >> review_request.update_from_commit_id(commit_id) >> File >> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/reviews/models/base_review_request_details.py", >> line 220, in update_from_commit_id >> self.update_from_committed_change(commit_id) >> File >> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/reviews/models/base_review_request_details.py", >> line 283, in update_from_committed_change >> base_commit_id=commit.base_commit_id) >> File >> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/diffviewer/managers.py", >> line 441, in create_from_data >> check_existence=(not parent_diff_file_contents))) >> File >> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/diffviewer/managers.py", >> line 586, in _process_files >> base_commit_id) >> FileNotFoundError: The file '/some/path/SomeFile.cs' (r) could not be >> found in the repository >> Show less >> >> >> >> >> On Monday, June 20, 2016 at 12:10:56 PM UTC-4, David Trowbridge wrote: >>> >>> Are there any errors in the Review Board log file? >>> >>> -David >>> On Mon, Jun 20, 2016 at 9:09 AM Joe Cooper <joe.c...@socketlabs.com> >>> wrote: >>> >>>> Hi, >>>> >>>> My team is using Review Board version 2.5.3. >>>> >>>> We are using a github hosted repo. We create review requests by >>>> selecting a repo -> branch -> and then selecting the commit to review on >>>> the web interface. >>>> >>>> Sometimes, the diff is not generated for the review. That is, the Diffs >>>> tab is not available and the Diff Size is blank even though the commit >>>> includes a lot of diffs. The last time this happened, the commit in >>>> question happened before a merge. The merge commit generates diffs just >>>> fine. >>>> >>>> So far we have tried: >>>> 1. Deleting reviews permanently and recreating >>>> 2. Recreating using different users >>>> 3. Rebooting the server hosting reviewboard web app >>>> >>>> None of these have worked. Does anyone have a suggestion as this is a >>>> bit of a show-stopper in terms of us being able to use this tool for >>>> reviews. >>>> >>>> Thanks in advance, >>>> Joe >>>> >>>> -- >>>> Supercharge your Review Board with Power Pack: >>>> https://www.reviewboard.org/powerpack/ >>>> Want us to host Review Board for you? Check out RBCommons: >>>> https://rbcommons.com/ >>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "reviewboard" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to reviewboard...@googlegroups.com. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
