narendly commented on a change in pull request #642: Fix zk session race
condition before creating a live instance
URL: https://github.com/apache/helix/pull/642#discussion_r353569061
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -1099,8 +1098,14 @@ public void handleStateChanged(KeeperState state) {
@Override
public void handleNewSession() throws Exception {
- LOG.info(
- "Handle new session, instance: " + _instanceName + ", type: " +
_instanceType);
+ handleNewSession(null);
+ }
+
+ @Override
+ public void handleNewSession(final String sessionId) throws Exception {
Review comment:
This public method should ideally have some JavaDoc describing what it does
and why it should be used, and how it's different from the one without any
parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
