narendly commented on a change in pull request #642: Fix zk session race
condition before creating a live instance
URL: https://github.com/apache/helix/pull/642#discussion_r353578476
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
##########
@@ -165,6 +166,27 @@ public void recordPathStat(Stat stat, OptionalLong
notificationTime) {
}
}
+ private abstract class SessionAwareCallable<T> implements Callable<T> {
+ protected volatile String sessionId;
+ protected volatile ZooKeeper zookeeper;
Review comment:
Actually, let's be careful here. We should only fail if mode is ephemeral.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
