narendly commented on a change in pull request #642: Fix zk session race
condition before creating a live instance
URL: https://github.com/apache/helix/pull/642#discussion_r353578879
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
##########
@@ -858,21 +931,30 @@ private void reconnect() {
}
}
- private void fireNewSessionEvents() {
+ private void fireNewSessionEvents(final String sessionId) {
Review comment:
+1. Or put a clear TODO and create a corresponding issue and link it here? I
also agree with @jiajunwang 's observation that if we proactively remove events
with non-matching sessionIds, that would help this case greatly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
