narendly commented on a change in pull request #642: Fix zk session race
condition before creating a live instance
URL: https://github.com/apache/helix/pull/642#discussion_r353576546
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
##########
@@ -158,7 +162,7 @@ private void joinCluster() {
}
}
- private void createLiveInstance() {
+ private void createLiveInstance(final String sessionId) {
Review comment:
My 2 cents from our discussion offline.
Since we've had some issues with keeping the sessionId as an internal state
(like _sessionId as a private variable), I prefer to take it in as the method
parameter to do away with any state. This way, we don't treat sessionId as an
internal state and its lifecycle will coincide with that of the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
