narendly commented on a change in pull request #642: Fix zk session race
condition before creating a live instance
URL: https://github.com/apache/helix/pull/642#discussion_r353578634
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
##########
@@ -568,6 +612,31 @@ public void createEphemeral(final String path, final
Object data)
create(path, data, CreateMode.EPHEMERAL);
}
+ /**
+ * Create a session aware ephemeral node. Given an expected non-zero session
id, if the ephemeral
Review comment:
Nit: Probably should check for an empty string as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
