narendly commented on a change in pull request #785: Fix the
ConcurrentModificationException in ClusterEvent.java
URL: https://github.com/apache/helix/pull/785#discussion_r381822180
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/ClusterEvent.java
##########
@@ -55,6 +55,19 @@ public ClusterEvent(String clusterName, ClusterEventType
eventType, String event
_eventId = eventId;
}
+ /**
Review comment:
Thanks for the PR!
1. Can we just replace clone() logic with what you have in the copy
constructor? If the constructor is private, then I think it'd just be simpler
to put this "copy" logic in clone() (it seems pretty simple anyways).
2. With that said, do we still need addAttribute() anymore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
