i3wangyi commented on a change in pull request #785: Fix the
ConcurrentModificationException in ClusterEvent.java
URL: https://github.com/apache/helix/pull/785#discussion_r382356368
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/ClusterEvent.java
##########
@@ -55,6 +55,19 @@ public ClusterEvent(String clusterName, ClusterEventType
eventType, String event
_eventId = eventId;
}
+ /**
Review comment:
That's really what I thought initially. But it turns out the variable
`_eventAttributeMap` is `final`, which means I cannot mutate the value.
Are you also referring to this
```
ClusterEvent newEvent = new ClusterEvent(_clusterName, _eventType, eventId);
return new ClusterEvent(this, eventId);
newEvent.setCreationTime(_creationTime);
newEvent._eventAttributeMap = new HashMap(__eventAttributeMap);
```
Unless we change the map to `non-final`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
