pkuwm commented on a change in pull request #785: Fix the
ConcurrentModificationException in ClusterEvent.java
URL: https://github.com/apache/helix/pull/785#discussion_r381845980
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/ClusterEvent.java
##########
@@ -114,11 +127,6 @@ public String toString() {
}
public ClusterEvent clone(String eventId) {
- ClusterEvent newEvent = new ClusterEvent(_clusterName, _eventType,
eventId);
- newEvent.setCreationTime(_creationTime);
- for (String attributeName : _eventAttributeMap.keySet()) {
Review comment:
@i3wangyi I am a bit confused and not convinced by the root cause: "In
ClusterEvent.java, the hashmap update itself while in its for loop".
The maps _eventAttributeMap are different objects. So addAttribute() does
not add the attributes to the original event's map, but the new event's
different map.
So I think the root cause could be another place (eg. another thread)
updating the original event's map while in for loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
