i3wangyi commented on a change in pull request #785: Fix the
ConcurrentModificationException in ClusterEvent.java
URL: https://github.com/apache/helix/pull/785#discussion_r382767073
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/ClusterEvent.java
##########
@@ -114,11 +127,6 @@ public String toString() {
}
public ClusterEvent clone(String eventId) {
- ClusterEvent newEvent = new ClusterEvent(_clusterName, _eventType,
eventId);
- newEvent.setCreationTime(_creationTime);
- for (String attributeName : _eventAttributeMap.keySet()) {
Review comment:
@pkuwm Thanks! I was under the impression that copy over a map is a
thread-safe operation in some languages(python, e.g). I just tried it in Java,
it still suffers the same exception. So I believe the right fix & less code
change is to make it ConcurrentHashMap. Also added a test for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
