i3wangyi commented on a change in pull request #785: Fix the
ConcurrentModificationException in ClusterEvent.java
URL: https://github.com/apache/helix/pull/785#discussion_r382357334
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/ClusterEvent.java
##########
@@ -114,11 +127,6 @@ public String toString() {
}
public ClusterEvent clone(String eventId) {
- ClusterEvent newEvent = new ClusterEvent(_clusterName, _eventType,
eventId);
- newEvent.setCreationTime(_creationTime);
- for (String attributeName : _eventAttributeMap.keySet()) {
Review comment:
You're right! I'll update the root cause in #785. I was initially unaware of
the different objects of `_eventAttributeMap`, cause the old code is readable
at first sight and it's not thread-safe.
This fix is still valid under multi-threads. Added one test but making it
multi-threading and produce the same issue is non-trivial.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
