pkuwm commented on a change in pull request #1218:
URL: https://github.com/apache/helix/pull/1218#discussion_r465915399
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/task/TestNoDoubleAssign.java
##########
@@ -155,11 +155,16 @@ private void pollForDoubleAssign() {
* Randomly causes Participants to lost connection temporarily.
*/
private void breakConnection() {
+ // Note, send to THREAD_COUNT == 1 is a must to avoid leaking
ClusterManager (participant).
+ // Otherwise, multiple thread has race of stopping and starting the same
slot of index
+ // this would cause a vast amount hundreds to thousand leaking threads.
+ // The design of this test itself relys on randomness too, which is also
not a good idea.
_executorServiceConnection =
Executors.newScheduledThreadPool(THREAD_COUNT);
_executorServiceConnection.scheduleAtFixedRate(() -> {
// Randomly pick a Participant and cause a transient connection issue
int participantIndex = RANDOM.nextInt(_numNodes);
- _participants[participantIndex].disconnect();
+ // _participants[participantIndex].disconnect();
Review comment:
Remove this instead of commenting it out?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
