mgao0 commented on a change in pull request #1218:
URL: https://github.com/apache/helix/pull/1218#discussion_r467202562
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/task/TestNoDoubleAssign.java
##########
@@ -155,11 +155,16 @@ private void pollForDoubleAssign() {
* Randomly causes Participants to lost connection temporarily.
*/
private void breakConnection() {
+ // Note, send to THREAD_COUNT == 1 is a must to avoid leaking
ClusterManager (participant).
Review comment:
@kaisun2000 Can you help me understand why THREAD_COUNT == 1 is a must
to avoid leaking ClusterManager (participant)? Does it cause leakage even we
shut down the executor after test?
In my understanding, the thread count there doesn't necessarily mean that
this executor will use this number of threads at most. This number is for the
core thread number, so more like a minimum number concept. If there's a need,
the executor will allocate more threads to handle the tasks even though
THREAD_COUNT is specified as 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
