jiajunwang commented on a change in pull request #1218:
URL: https://github.com/apache/helix/pull/1218#discussion_r467282073
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/task/TestNoDoubleAssign.java
##########
@@ -155,11 +155,16 @@ private void pollForDoubleAssign() {
* Randomly causes Participants to lost connection temporarily.
*/
private void breakConnection() {
+ // Note, send to THREAD_COUNT == 1 is a must to avoid leaking
ClusterManager (participant).
Review comment:
@kaisun2000 if that's the only reason, then we can just add a concurrent
control on the stop, start block?
Moreover, I believe startParticipant will auto close it if one object is
already running. We can also add synchronize there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
