kaisun2000 commented on a change in pull request #1218:
URL: https://github.com/apache/helix/pull/1218#discussion_r467300538
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/task/TestNoDoubleAssign.java
##########
@@ -155,11 +155,16 @@ private void pollForDoubleAssign() {
* Randomly causes Participants to lost connection temporarily.
*/
private void breakConnection() {
+ // Note, send to THREAD_COUNT == 1 is a must to avoid leaking
ClusterManager (participant).
Review comment:
> I believe startParticipant will auto close it if one object is already
running. We can also add synchronize there.
Yes, it has. But over there still boils down to single thread execution. It
does not increase parallism in this case. The above code seems to be clear in
terms that we wan to stress that cleaning the resource by stopping it. Or we
need to think about object life cycle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
