kaisun2000 commented on a change in pull request #1218:
URL: https://github.com/apache/helix/pull/1218#discussion_r467290435



##########
File path: 
helix-core/src/test/java/org/apache/helix/integration/task/TestNoDoubleAssign.java
##########
@@ -155,11 +155,16 @@ private void pollForDoubleAssign() {
    * Randomly causes Participants to lost connection temporarily.
    */
   private void breakConnection() {
+    // Note, send to THREAD_COUNT == 1 is a must to avoid leaking 
ClusterManager (participant).

Review comment:
       something like this? I can give it a try. But it basically boils down to 
single thread case anyway. 
   
   ```
   _executorServiceConnection.scheduleAtFixedRate(() -> {
         // Randomly pick a Participant and cause a transient connection issue
        synchronized (_executorServiceConnection) {
         int participantIndex = RANDOM.nextInt(_numNodes);
         stopParticipant(participantIndex);
         startParticipant(participantIndex);
         }
     }, 0L, CONNECTION_DELAY, TimeUnit.MILLISECONDS);
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to