jiajunwang commented on a change in pull request #1218:
URL: https://github.com/apache/helix/pull/1218#discussion_r472434008
##########
File path: helix-core/src/test/resources/log4j.properties
##########
@@ -16,7 +16,11 @@
# specific language governing permissions and limitations
# under the License.
#
+
+# Set root logger level to DEBUG and its only appender to R.
Review comment:
Remove the unnecessary comments?
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/rebalancer/DelayedAutoRebalancer/TestDelayedAutoRebalance.java
##########
@@ -49,7 +49,7 @@
protected static final int PARTITIONS = 5;
// TODO: remove this wait time once we have a better way to determine if the
rebalance has been
// TODO: done as a reaction of the test operations.
- protected static final int DEFAULT_REBALANCE_PROCESSING_WAIT_TIME = 1000;
+ protected static final int DEFAULT_REBALANCE_PROCESSING_WAIT_TIME = 3000;
Review comment:
Are we sure this is causing the trouble?
Based on what I tested before, 1 second is already a very long time. If with
1 second, the test is still not stable, then it might be other problems.
Let me be clear,
1. Changing this time just prolong the test, not a big deal.
2. I'm more concerned that this won't really make the tests more stable.
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/task/TestNoDoubleAssign.java
##########
@@ -158,9 +158,11 @@ private void breakConnection() {
_executorServiceConnection =
Executors.newScheduledThreadPool(THREAD_COUNT);
_executorServiceConnection.scheduleAtFixedRate(() -> {
// Randomly pick a Participant and cause a transient connection issue
- int participantIndex = RANDOM.nextInt(_numNodes);
- _participants[participantIndex].disconnect();
- startParticipant(participantIndex);
+ synchronized (this){
Review comment:
In this case, shall we lock all the start/stop callers?
I think a better way is to lock inside the start and stop methods. Then add
a reset method in addition which requests the same lock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
