lei-xia commented on a change in pull request #1227:
URL: https://github.com/apache/helix/pull/1227#discussion_r475809892
##########
File path:
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -236,6 +239,9 @@ protected synchronized boolean verifyState() {
idealStates.entrySet()
.removeIf(pair ->
pair.getValue().getStateModelDefRef().equals(TaskConstants.STATE_MODEL_NAME));
+ if (_isLogMore) {
+ System.out.println("---- before verify instances !");
+ }
Review comment:
Can we get rid of all these println statement in prod code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
