lei-xia commented on a change in pull request #1227:
URL: https://github.com/apache/helix/pull/1227#discussion_r475810574
##########
File path:
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/ZkHelixClusterVerifier.java
##########
@@ -48,6 +50,10 @@
private static Logger LOG =
LoggerFactory.getLogger(ZkHelixClusterVerifier.class);
protected static int DEFAULT_TIMEOUT = 300 * 1000;
protected static int DEFAULT_PERIOD = 500;
+ // COOL_DOWN before starting vefiyByPool
+ // The goal is to make sure waiting for controller pipeline starts at least
one cycle
+ // to update ideal state.
+ protected static int DEFAULT_COOLDOWN = 2 * 1000;
Review comment:
Set a hardcoded time here is not a good idea, these tools have been used
by many of customers, including Espresso, how do we know 2 second is good
enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
