xyuanlu commented on code in PR #2595:
URL: https://github.com/apache/helix/pull/2595#discussion_r1294104455
##########
helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java:
##########
@@ -1173,4 +1177,22 @@ public String getInstanceHelixDisabledTimeStamp(String
instanceName) {
}
return getDisabledInstances().get(instanceName);
}
+
+ /**
+ * @return: a unix time that represents the last time the on demand
rebalance is triggered on
+ * current cluster. Return -1 if the configuration doesn't have such record
yet.
+ */
+ public long getLastOnDemandRebalanceTimestamp() {
+ return
_record.getLongField(ClusterConfigProperty.LAST_ON_DEMAND_REBALANCE_TIMESTAMP.name(),
+ LAST_ON_DEMAND_REBALANCE_TIMESTAMP_NOT_SET);
Review Comment:
nit: may consider change name. Current name sounds like an exception name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
