MarkGaox commented on code in PR #2595:
URL: https://github.com/apache/helix/pull/2595#discussion_r1294946128
##########
helix-core/src/test/java/org/apache/helix/common/ZkTestBase.java:
##########
@@ -356,6 +356,14 @@ protected void setDelayTimeInCluster(HelixZkClient
zkClient, String clusterName,
configAccessor.setClusterConfig(clusterName, clusterConfig);
}
+ protected void setLastOnDemandRebalanceTimeInCluster(HelixZkClient zkClient,
Review Comment:
It's seems like `ZkTestBase` is only be used by it's subclasses. And all
`protected` methods from `ZkTestBase` can be directly called by it's
subclasses. So static is not needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
