zpinto commented on code in PR #2595:
URL: https://github.com/apache/helix/pull/2595#discussion_r1296116918


##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/DelayedRebalanceUtil.java:
##########
@@ -135,9 +135,17 @@ private static Set<String> getActiveNodes(Set<String> 
allNodes, Set<String> live
   private static long getInactiveTime(String instance, Set<String> 
liveInstances, Long offlineTime,

Review Comment:
   Can you update the description in the docstring of this function here to 
reflect how force rebalance affects inactive time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to