MarkGaox commented on code in PR #2595:
URL: https://github.com/apache/helix/pull/2595#discussion_r1296251942


##########
helix-core/src/test/java/org/apache/helix/integration/rebalancer/DelayedAutoRebalancer/TestDelayedAutoRebalanceWithDisabledInstance.java:
##########
@@ -292,6 +292,85 @@ public void testDisableDelayRebalanceInInstance() throws 
Exception {
     super.testDisableDelayRebalanceInInstance();
   }
 
+  @Test(dependsOnMethods = {"testDisableDelayRebalanceInInstance"})
+  @Override

Review Comment:
   `testOnDemandRebalance` in `TestDelayedAutoRebalance.java` tests only 
offline nodes. `testOnDemandRebalance` in 
`TestDelayedAutoRebalanceWithDisabledInstance.java` is for disabled instances.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to