MarkGaox commented on code in PR #2595:
URL: https://github.com/apache/helix/pull/2595#discussion_r1296260980
##########
helix-core/src/test/java/org/apache/helix/integration/rebalancer/DelayedAutoRebalancer/TestDelayedAutoRebalanceWithDisabledInstance.java:
##########
@@ -292,6 +292,85 @@ public void testDisableDelayRebalanceInInstance() throws
Exception {
super.testDisableDelayRebalanceInInstance();
}
+ @Test(dependsOnMethods = {"testDisableDelayRebalanceInInstance"})
+ @Override
Review Comment:
Or do you think it would be better to factor that out? Well..I personally
feel like not factoring this out could be more intuitive. And In the future if
you have more features you wanna to `disabled` nodes only or `offline` nodes
only, then you can modify the test accordingly without touching the
counterparts (And I believe it's gonna happen shortly when you implementing
node swag). Just my two cents. And we can sync up offline today. ^_^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
