xyuanlu commented on code in PR #2595:
URL: https://github.com/apache/helix/pull/2595#discussion_r1296407955
##########
helix-core/src/test/java/org/apache/helix/integration/rebalancer/DelayedAutoRebalancer/TestDelayedAutoRebalanceWithDisabledInstance.java:
##########
@@ -292,6 +292,85 @@ public void testDisableDelayRebalanceInInstance() throws
Exception {
super.testDisableDelayRebalanceInInstance();
}
+ @Test(dependsOnMethods = {"testDisableDelayRebalanceInInstance"})
+ @Override
Review Comment:
The change we made in this PR is in how we filter out instances for further
stages in pipeline. Since no changes are made in further pipeline, we don't
need to add test for every single rebalance flavor.
We do need to test when there are disabled or offline instances. We could
test them in the same unit test. Having duplicate code is not a good practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
