zpinto opened a new pull request, #2641:
URL: https://github.com/apache/helix/pull/2641
Allow for callers to helix-rest stoppable APIs to skip running
CUSTOM_INSTANCE_CHECK and(or) CUSTOM_PARTITION_CHECK, as they may not have the
need to implement additional custom checks.
### Description
Customers are required to implement custom stoppable checks to use
helix-rest stoppable APIs. Making these skippable removes that requirement.
### Tests
- [x]
testGetInstanceStoppableCheckWhenCustomInstanceCheckAndCustomPartitionCheckDisabled
- Verifies none of the custom checks cause stoppable to be false
- [x] testGetInstanceStoppableCheckWhenCustomPartitionCheckDisabled
- Verifies instance custom check causes stoppable to be false
- [x] testGetInstanceStoppableCheckWhenCustomInstanceCheckDisabled
- Verifies partition custom check causes stoppable to be false
- [x] Update TestPerInstanceAccessor and TestInstanceAccessor to make sure
they can parse skipHealthCheckCategories
```
➜ helix git:(custom_stoppable_checks_optional) ✗ mvn clean install
-Dmaven.test.skip.exec=true && mvn test -o
-Dtest=TestMaintenanceManagementService,TestInstancesAccessor,TestPerInstanceAccessor
-pl=helix-rest
...
[INFO] Tests run: 37, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
127.184 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 37, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco:0.8.6:report (generate-code-coverage-report) @ helix-rest
---
[INFO] Loading execution data file
/Users/zapinto/Documents/git/zpinto/helix/helix-rest/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Restful Interface' with 92 classes
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 02:19 min
[INFO] Finished at: 2023-10-04T18:59:33-07:00
[INFO]
------------------------------------------------------------------------
```
### Changes that Break Backward Compatibility (Optional)
- Changes are backwards compatible
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
