desaikomal commented on code in PR #2641:
URL: https://github.com/apache/helix/pull/2641#discussion_r1348922031
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java:
##########
@@ -81,43 +82,65 @@ public class MaintenanceManagementService {
public static final String HELIX_CUSTOM_STOPPABLE_CHECK =
"CustomInstanceStoppableCheck";
public static final String OPERATION_CONFIG_SHARED_INPUT =
"OperationConfigSharedInput";
+ public static final Set<StoppableCheck.Category>
SKIPPABLE_HEALTH_CHECK_CATEGORIES =
+ ImmutableSet.of(StoppableCheck.Category.CUSTOM_INSTANCE_CHECK,
+ StoppableCheck.Category.CUSTOM_PARTITION_CHECK);
+
private final ConfigAccessor _configAccessor;
private final CustomRestClient _customRestClient;
private final String _namespace;
private final boolean _skipZKRead;
private final HelixDataAccessorWrapper _dataAccessor;
private final Set<String> _nonBlockingHealthChecks;
+ private final Set<StoppableCheck.Category> _skipHealthCheckCategories;
public MaintenanceManagementService(ZKHelixDataAccessor dataAccessor,
ConfigAccessor configAccessor, boolean skipZKRead, String namespace) {
- this(dataAccessor, configAccessor, CustomRestClientFactory.get(),
skipZKRead,
+ this(new HelixDataAccessorWrapper(dataAccessor,
CustomRestClientFactory.get(), namespace),
Review Comment:
this makes sense. thanks
##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java:
##########
@@ -150,19 +149,34 @@ public Response getAllInstances(@PathParam("clusterId")
String clusterId,
@ResponseMetered(name = HttpConstants.WRITE_REQUEST)
@Timed(name = HttpConstants.WRITE_REQUEST)
@POST
- public Response instancesOperations(
- @PathParam("clusterId") String clusterId,
+ public Response instancesOperations(@PathParam("clusterId") String clusterId,
@QueryParam("command") String command,
@QueryParam("continueOnFailures") boolean continueOnFailures,
@QueryParam("skipZKRead") boolean skipZKRead,
- String content) {
+ @QueryParam("skipHealthCheckCategories") String
skipHealthCheckCategories, String content) {
Review Comment:
i thought we had many but looks like we only have 3 in total and 2 you are
already allowing to specify
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java:
##########
@@ -81,43 +82,65 @@ public class MaintenanceManagementService {
public static final String HELIX_CUSTOM_STOPPABLE_CHECK =
"CustomInstanceStoppableCheck";
public static final String OPERATION_CONFIG_SHARED_INPUT =
"OperationConfigSharedInput";
+ public static final Set<StoppableCheck.Category>
SKIPPABLE_HEALTH_CHECK_CATEGORIES =
Review Comment:
Totally there are 3 categories, Helix and then instance check and
partition-check. So we will allow them to skip either or both. Helix is
non-skippable. is that correct?
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java:
##########
@@ -465,6 +495,8 @@ private List<String>
batchCustomInstanceStoppableCheck(String clusterId, List<St
}
return instancesForFollowingChecks;
}
+
+ // This means that we skipped
Review Comment:
or user didn't have any custom checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
