zpinto commented on code in PR #2641:
URL: https://github.com/apache/helix/pull/2641#discussion_r1347831783
##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java:
##########
@@ -150,19 +149,34 @@ public Response getAllInstances(@PathParam("clusterId")
String clusterId,
@ResponseMetered(name = HttpConstants.WRITE_REQUEST)
@Timed(name = HttpConstants.WRITE_REQUEST)
@POST
- public Response instancesOperations(
- @PathParam("clusterId") String clusterId,
+ public Response instancesOperations(@PathParam("clusterId") String clusterId,
@QueryParam("command") String command,
@QueryParam("continueOnFailures") boolean continueOnFailures,
@QueryParam("skipZKRead") boolean skipZKRead,
- String content) {
+ @QueryParam("skipHealthCheckCategories") String
skipHealthCheckCategories, String content) {
Review Comment:
I don't think it makes since to support skipAllHealthChecks otherwise there
would be no point to call the stoppable API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
