zpinto commented on code in PR #2641:
URL: https://github.com/apache/helix/pull/2641#discussion_r1347832674
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java:
##########
@@ -81,43 +82,65 @@ public class MaintenanceManagementService {
public static final String HELIX_CUSTOM_STOPPABLE_CHECK =
"CustomInstanceStoppableCheck";
public static final String OPERATION_CONFIG_SHARED_INPUT =
"OperationConfigSharedInput";
+ public static final Set<StoppableCheck.Category>
SKIPPABLE_HEALTH_CHECK_CATEGORIES =
+ ImmutableSet.of(StoppableCheck.Category.CUSTOM_INSTANCE_CHECK,
+ StoppableCheck.Category.CUSTOM_PARTITION_CHECK);
+
private final ConfigAccessor _configAccessor;
private final CustomRestClient _customRestClient;
private final String _namespace;
private final boolean _skipZKRead;
private final HelixDataAccessorWrapper _dataAccessor;
private final Set<String> _nonBlockingHealthChecks;
+ private final Set<StoppableCheck.Category> _skipHealthCheckCategories;
public MaintenanceManagementService(ZKHelixDataAccessor dataAccessor,
ConfigAccessor configAccessor, boolean skipZKRead, String namespace) {
- this(dataAccessor, configAccessor, CustomRestClientFactory.get(),
skipZKRead,
+ this(new HelixDataAccessorWrapper(dataAccessor,
CustomRestClientFactory.get(), namespace),
Review Comment:
This makes it possible to mock HelixDataAccessorWrapper in tests. If you
create the object in the final constructor, you cannot mock it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
